Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Option worker definition optionally as string reference. #417

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jiw-mh
Copy link
Contributor

@jiw-mh jiw-mh commented Jan 20, 2025

This is a stab at a reference defining the worker reference following the discussion in #415

@mnapoli
Copy link
Member

mnapoli commented Jan 20, 2025

Thanks!

I wonder if this could work instead:

functions:
    foo:
        handler: worker.handler

constructs:
    emails:
        type: queue
        worker: foo

that would be simpler.

@jiw-mh
Copy link
Contributor Author

jiw-mh commented Jan 20, 2025

Does Serverless support varied types?

@mnapoli
Copy link
Member

mnapoli commented Jan 20, 2025

This pattern is very common in serverless.yml (string or object value).

@jiw-mh jiw-mh changed the title Feature: Option workerRef Feature: Option worker definition optionally as string reference. Jan 21, 2025
@jiw-mh
Copy link
Contributor Author

jiw-mh commented Jan 21, 2025

I think I figured out how to specify the function and updated the PR to make worker optionally as a string

@mnapoli
Copy link
Member

mnapoli commented Jan 21, 2025

Can you document this new feature here: https://github.com/getlift/lift/blob/master/docs/queue.md#worker

Also I think it might be worth rebasing after we merge #416 so that we get a clear picture of the CI.

@jiw-mh
Copy link
Contributor Author

jiw-mh commented Jan 22, 2025

@mnapoli I added some documentation and rebased the branch.

@jiw-mh
Copy link
Contributor Author

jiw-mh commented Jan 30, 2025

@mnapoli is there something else I can do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants