reduce aliases in subqueries

getodk · Feb 7, 2025 · 835d5b7 · 835d5b7
1 parent 245958e
commit 835d5b7
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/lib/model/query/analytics.js b/lib/model/query/analytics.js
@@ -444,7 +444,7 @@ const getDatasets = () => ({ all }) => all(sql`
        , COALESCE(creates.create_api_recent       , 0) AS num_entity_create_api_recent
        , COALESCE(bulk_creates.total              , 0) AS num_entity_create_bulk_total
        , COALESCE(bulk_creates.recent             , 0) AS num_entity_create_bulk_recent
-  FROM datasets ds
+  FROM datasets AS ds
     LEFT JOIN (
       SELECT "datasetId"
            , COUNT(id) AS num_entities_total
@@ -462,12 +462,12 @@ const getDatasets = () => ({ all }) => all(sql`
         GROUP BY dfd."datasetId"
     ) AS fd ON fd."datasetId" = ds.id
     LEFT JOIN (
-      SELECT fa."datasetId"
-           , COUNT(fa."formId") AS num_followup_forms
-        FROM form_attachments AS fa
-          JOIN forms AS f ON f.id = fa."formId"
+      SELECT "datasetId"
+           , COUNT("formId") AS num_followup_forms
+        FROM form_attachments
+          JOIN forms AS f ON f.id = "formId"
         WHERE f."currentDefId" IS NOT NULL
-        GROUP BY fa."datasetId"
+        GROUP BY "datasetId"
     ) AS fa ON fa."datasetId" = ds.id
     LEFT JOIN (
       SELECT COUNT(a.details->'submissionId') AS total