Submission submission via Webforms #1125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brontolosone
force-pushed
the
wf23_webforms-in-central
branch
from
39de8c8 to
83caae4
Compare
This was referenced Jan 22, 2025
sadiqkhoja
force-pushed
the
wf23_webforms-in-central
branch
2 times, most recently
from
e82d6d7 to
fd66477
Compare
…orms supports it)
* created separate components to render Enketo vs ODK-Web-Forms * handle draft submissions * redirect on Enketo submission * all routes are now async * webhistory based navigation instead of hash-based * show correct URL in public links page
sadiqkhoja
force-pushed
the
wf23_webforms-in-central
branch
from
fd66477 to
0cac584
Compare
sadiqkhoja
reviewed
Mar 5, 2025
|
|
||
| location ~* "^/-/(?<enketoPath>single|X)/(?<enketoId>[a-zA-Z0-9]{31})" { | ||
| # Form fill link, public | ||
| if ($request_method = GET) { |
There was a problem hiding this comment.
I think this if condition is not necessary because we only send GET request to this location
sadiqkhoja
reviewed
Mar 5, 2025
| </template> | ||
| </modal> | ||
|
|
||
| <modal v-bind="submissionModal" hideable backdrop @hide="submissionModal.hide()"> |
There was a problem hiding this comment.
this modal can be move to separate file, but I am expecting UI changes to this so I will move it along with those changes.
sadiqkhoja
reviewed
Mar 5, 2025
Comment on lines
+509
to
+514
| }, | ||
| "formSetting": { | ||
| "formTech": "Web based form technology", | ||
| "enableWebForms": "Use WebForms instead of Enketo", | ||
| "enableWebFormsExplanation": "When users fill out forms via the web (not via ODK Collect), we use Enketo by default. Its successor is \"WebForms\", which is a work in progress that you can already test.", | ||
| "enableWebFormsExplanationLinktext": "Before enabling this, read up on WebForms and which form features it currently supports!" |
There was a problem hiding this comment.
I am thinking to remove these translations and enter static text since they might change
sadiqkhoja
reviewed
Mar 5, 2025
| @@ -96,12 +96,18 @@ export default { | |||
|
|
|||
| $border-height: 3px; | |||
|
|
|||
| :root { | |||
There was a problem hiding this comment.
I don't remember why this change was made, I should revert this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes getodk/web-forms#23 and getodk/central#883
Underlying strategy: redirect the Enketo URLs for form filling, previewing, public links etc to central-frontend routes. Then decide dynamically (based on a form's settings) whether to use Webforms, or Enketo after all (in an iframe).
See Google doc, Jan 21 meeting notes for loose ends.
Depends on: #1141 should be merged first.
This branch still uses web-forms#v0.6.0 that doesn't emits submission payload, hence I have kept dead code in here. I will enable that code in the related PR when a new version of web-forms is available.
There is one unanswered question about what to do when session times out while filling out the Form, that will be handle in getodk/central#910.
Another known issue to me is that if you copy the URL from the "New Submission" button and paste it in a new browser or incognito window, you will see error message instead of login page. I don't if that's important to fix. I can fix it with getodk/central#910 if required.