Request entity versions in EntityShow, not diffs #880
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a precursor to getodk/central#505 and getodk/central#507. On the entity detail page, we need additional information about entity versions (from the …/versions endpoint). Once we have that information, we will no longer need information from the …/diffs endpoint that the page currently requests. In other words, this PR replaces the request to …/diffs with a request to …/versions.
What has been done to verify that this works as intended?
Just making sure that tests continue to pass.
Why is this the best possible solution? Were any other approaches considered?
There's now a little more logic around the diff shown in
EntityFeedEntry
. For example, we can useserverDiff
to determine the names of changed properties, but we also need to determine which version was the server version at the time in order to retrieve its value for each changed property. For that reason, I've moved the diff into its own component,EntityDiff
. That component will get more complicated as we work on getodk/central#507.Before submitting this PR, please make sure you have:
npm run test
andnpm run lint
and confirmed all checks still pass OR confirm CircleCI build passes