Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address comments for PR 6440 #6481

Merged
merged 8 commits into from
Oct 30, 2024
Merged

Address comments for PR 6440 #6481

merged 8 commits into from
Oct 30, 2024

Commits on Oct 29, 2024

  1. Changed var to val

    @grzesiek2010
    grzesiek2010 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    ab81ee9 View commit details
    Browse the repository at this point in the history

  2. Revert "Keep ChangeLock inteface and its only implementation in one f… 

    …ile"

This reverts commit 6cceed3.
    @grzesiek2010
    grzesiek2010 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    a1b0cb8 View commit details
    Browse the repository at this point in the history

  3. Revert "Removed redundant BooleanChangeLock" 

    This reverts commit 1bd04b2.
    @grzesiek2010
    grzesiek2010 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    94ed012 View commit details
    Browse the repository at this point in the history

  4. Removed redundant casts

    @grzesiek2010
    grzesiek2010 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    f7b5c3e View commit details
    Browse the repository at this point in the history

  5. Add #lock method for easier testing

    @grzesiek2010
    grzesiek2010 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    00108f9 View commit details
    Browse the repository at this point in the history

  6. Improved ThreadSafeBooleanChangeLockTest

    @grzesiek2010
    grzesiek2010 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    86620b9 View commit details
    Browse the repository at this point in the history

  7. Test both implementations of ChangeLock

    @grzesiek2010
    grzesiek2010 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    d7300a3 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Use synchronized in #lock

    @grzesiek2010
    grzesiek2010 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    6856223 View commit details
    Browse the repository at this point in the history