chore: Promote rc to stable #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`DIR` is a common pattern used in devbase to determine the current running directory. Unfortunately, some of our libraries have _also_ started to use it. This ends up in secenarios where `DIR` can be overwritten by an imported script. To avoid this, we've used `LIB_DIR` inside the libraries to prevent clashes from causing an issue. In reality, we shouldn't be using Bash which would help... for now this fixes it by changing the newly added `DIR` to be `LIB_DIR`.
yj-yan
approved these changes
Dec 6, 2023
malept
approved these changes
Dec 6, 2023
|
🎉 This PR is included in version 2.23.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promote rc to stable, created by
dt release promoteDO NOT MERGE