feat: make go test timeout configurable in test job #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -53,6 +57,7 @@ executor: | |||
| environment: | |||
| AWS_REGION: << parameters.aws_region >> | |||
| PRE_SETUP_SCRIPT: << parameters.pre_setup_script >> | |||
| GO_TEST_TIMEOUT: << parameters.go_test_timeout >> | |||
There was a problem hiding this comment.
so i take it this is used in a script somewhere when we run the tests?
There was a problem hiding this comment.
Yup.
Lines 103 to 106 in be1b62d
malept
approved these changes
Jan 10, 2024
kaldorn
deleted the
feat-make-go-test-timeout-configurable-in-test-job
branch
|
🎉 This PR is included in version 2.24.0-rc.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read CONTRIBUTING.md for additional information on contributing to this repository!
What this PR does / why we need it
Unfortunately, I have a test that takes longer than 10 minutes and this isn't currently configurable.
The test.sh looks for this env var and sets the timeout flag:
devbase/shell/test.sh
Lines 103 to 106 in be1b62d
Jira ID
[XX-XX]
Notes for your reviewers