feat(aws): remove saml2aws support #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Linked to Story DT-4072 · Remove saml2aws from being installed |
yj-yan
approved these changes
Oct 25, 2023
jaredallard
approved these changes
Oct 25, 2023
|
🎉 This PR is included in version 1.82.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
malept
added a commit
that referenced
this pull request
Nov 6, 2023
## What this PR does / why we need it Fixes a regression in #384 and adds support for v2 of okta-aws-cli by checking the output of `okta-aws-cli --version`. Also updates the call to `okta-aws-cli` to directly set the appropriate `OKTA_*` environment variables from the box config, instead of relying on the parent shell environment. This caused problems when the external dependency that pulled the values from the box config into the shell environment broke on macOS. ## Jira ID [DT-4091] [DT-4091]: https://outreach-io.atlassian.net/browse/DT-4091?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Jared Allard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Remove the code to support use of
saml2awsfor AWS credentials as Outreach no longer uses it, while retaining the refactor to allow future non-okta-aws-cliimplementations if necessary.Notes for your reviewers
This doesn't completely remove all traces of
saml2awsas we still use their AWS credentials reader API to see if the credentials are expired.