Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws): add SessionDuration for okta-aws-cli #402

Merged
merged 5 commits into from
Nov 9, 2023
Merged

fix(aws): add SessionDuration for okta-aws-cli #402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
389977b
Add OKTA_AWSCLI_SESSION_DURATION
Nov 9, 2023
22e14d8
add SessionDuration to a box struct definition
Nov 9, 2023
e1fd8da
update comment and changed string to int
Nov 9, 2023
28a98df
need to change how we build value as its now an int
Nov 9, 2023
49b72d2
Merge branch 'main' into patclarke/okta-aws-cli-session
malept Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/box/box.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ type OktaConfig struct {
OIDCClientID string `yaml:"oidcClientID"`
// OrgDomain is the hostname of the Okta instance.
OrgDomain string `yaml:"orgDomain"`
// SessionDuration is the TTL for the session in seconds.
SessionDuration uint `yaml:"sessionDuration"`
}

type DeveloperEnvironmentConfig struct {
Expand Down
1 change: 1 addition & 0 deletions pkg/cli/aws/aws.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,7 @@ func runOktaAwsCLI(ctx context.Context, b *box.Config, args ...string) error {
"OKTA_ORG_DOMAIN="+b.AWS.Okta.OrgDomain,
"OKTA_AWS_ACCOUNT_FEDERATION_APP_ID="+b.AWS.Okta.FederationAppID,
"OKTA_OIDC_CLIENT_ID="+b.AWS.Okta.OIDCClientID,
fmt.Sprintf("OKTA_AWSCLI_SESSION_DURATION=%d", b.AWS.Okta.SessionDuration),
)
return cmd.Run()
}
Expand Down