feat: allow controlling of StartCall info logging from a service runtime #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeSme
force-pushed
the
infologging_ff_controls
branch
from
46d7e8e to
0ce1fb3
Compare
PeSme
force-pushed
the
infologging_ff_controls
branch
from
431e6c1 to
5dc2edf
Compare
PeSme
force-pushed
the
infologging_ff_controls
branch
2 times, most recently
from
38c2530 to
da2c8fd
Compare
PeSme
force-pushed
the
infologging_ff_controls
branch
2 times, most recently
from
de2a962 to
436b323
Compare
PeSme
force-pushed
the
infologging_ff_controls
branch
from
436b323 to
c96e589
Compare
PeSme
force-pushed
the
infologging_ff_controls
branch
from
c96e589 to
12fdfc6
Compare
PeSme
force-pushed
the
infologging_ff_controls
branch
from
ebbce9b to
ee32526
Compare
ekalinichev
force-pushed
the
infologging_ff_controls
branch
from
ee32526 to
3508bde
Compare
ekalinichev
reviewed
Oct 8, 2024
| []string{"app", "call", "statuscode", "statuscategory", "kind"}, // Labels | ||
| []string{"target", "call", "statuscode", "statuscategory", "kind"}, // Labels |
There was a problem hiding this comment.
@jan-ludvik I think we've found why we get two app names separated by comma, if we're right -- this PR will fix the issue. FYI.
ekalinichev
approved these changes
Oct 8, 2024
PeSme
force-pushed
the
infologging_ff_controls
branch
from
e8e6c5d to
ebe4e5e
Compare
PeSme
changed the title
honzap
approved these changes
Oct 8, 2024
|
🎉 This PR is included in version 1.98.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read CONTRIBUTING.md for additional information on contributing to this repository!
What this PR does / why we need it
Your service can implement custom evaluation function to control emission of trace.StartCall info logs from Go services in real time based on as granular conditions as you wish.
Notes for your reviewers