Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cfg): env secret/string support #592

Merged
merged 13 commits into from
Oct 14, 2024
Merged

feat(cfg): env secret/string support #592

merged 13 commits into from
Oct 14, 2024

Conversation

AndrewWinterman
Copy link
Contributor

Please read CONTRIBUTING.md for additional information on contributing to this repository!

What this PR does / why we need it

Jira ID

[XX-XX]

Notes for your reviewers

@AndrewWinterman AndrewWinterman requested a review from a team as a code owner October 11, 2024 23:08
malept
malept requested changes Oct 11, 2024
View reviewed changes
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems mostly fine but the tests should be using gotest.tools/v3/assert.

pkg/cfg/env.go Outdated Show resolved Hide resolved
pkg/cfg/env_test.go Outdated Show resolved Hide resolved
pkg/cfg/env_test.go Outdated Show resolved Hide resolved
pkg/cfg/env_test.go Outdated Show resolved Hide resolved
pkg/cfg/env_test.go Outdated Show resolved Hide resolved
pkg/cfg/env_test.go Outdated Show resolved Hide resolved
pkg/cfg/env_test.go Outdated Show resolved Hide resolved
pkg/cfg/env_test.go Outdated Show resolved Hide resolved
pkg/cfg/env_test.go Outdated Show resolved Hide resolved
AndrewWinterman and others added 11 commits October 11, 2024 17:12
@AndrewWinterman @malept
Update pkg/cfg/env.go
52c7b2c 
Co-authored-by: Mark Lee <[email protected]>
@AndrewWinterman @malept
Update pkg/cfg/env_test.go
b1e7426 
Co-authored-by: Mark Lee <[email protected]>
@AndrewWinterman @malept
Update pkg/cfg/env_test.go
d17b8dd 
Co-authored-by: Mark Lee <[email protected]>
@AndrewWinterman @malept
Update pkg/cfg/env_test.go
d27372c 
Co-authored-by: Mark Lee <[email protected]>
@AndrewWinterman @malept
Update pkg/cfg/env_test.go
41a7a1b 
Co-authored-by: Mark Lee <[email protected]>
@AndrewWinterman @malept
Update pkg/cfg/env_test.go
c509bf8 
Co-authored-by: Mark Lee <[email protected]>
@AndrewWinterman @malept
Update pkg/cfg/env_test.go
f683ab4 
Co-authored-by: Mark Lee <[email protected]>
@AndrewWinterman @malept
Update pkg/cfg/env_test.go
28b606b 
Co-authored-by: Mark Lee <[email protected]>
@AndrewWinterman @malept
Update pkg/cfg/env_test.go
ec84970 
Co-authored-by: Mark Lee <[email protected]>
@AndrewWinterman
thanks mark
5f32501
@AndrewWinterman
undo accidental delete of go work files
400fa97
malept
malept approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine once the copyright date is changed.

pkg/cfg/env.go Outdated Show resolved Hide resolved
@AndrewWinterman @malept
Update pkg/cfg/env.go
cf24b21 
Co-authored-by: Mark Lee <[email protected]>
@AndrewWinterman AndrewWinterman enabled auto-merge (squash) October 14, 2024 17:03
@AndrewWinterman AndrewWinterman merged commit 07b206d into main Oct 14, 2024
4 checks passed
@AndrewWinterman AndrewWinterman deleted the feat/env-config branch October 14, 2024 17:16
@getoutreach-ci-1
Copy link
Contributor

🎉 This PR is included in version 1.100.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-dostal84 daniel-dostal84 daniel-dostal84 approved these changes

@malept malept malept approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrewWinterman @malept @daniel-dostal84