Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: print all errors in dev reader #605

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dundee
Copy link
Contributor

@dundee dundee commented Dec 5, 2024

Please read CONTRIBUTING.md for additional information on contributing to this repository!

What this PR does / why we need it

When service is being run locally (without devenv) and no config is present, the message says:

open /run/config/outreach.io/<service>.yaml: no such file or directory

Which is misleading as it doesn't say that the logic actually tried also paths in ~/.outreach.

With this PR it will show all the attempts if devReader fails:

failed to read config file "<SERVICE>.yaml": open /Users/danielmilde/.outreach/<SERVICE>/<SERVICE>.yaml: no such file or directory
failed to read config file "<SERVICE>.yaml": open /Users/danielmilde/.outreach/<SERVICE>.yaml: no such file or directory
{"@timestamp":"2024-12-05T13:51:22.988722+01:00","app.name":"<SERVICE>","app.version":"148390f","error.error":"failed to read config file \"<SERVICE>.yaml\": open /run/config/outreach.io/<SERVICE>.yaml: no such file or directory","error.kind":"error","error.message":"failed to read config file \"<SERVICE>.yaml\": open /run/config/outreach.io/<SERVICE>.yaml: no such file or directory","level":"ERROR","message":"failed to load config","module":"github.com/getoutreach/<SERVICE>","modulever":"148390f","service_name":"<SERVICE>"}

Jira ID

[XX-XX]

Notes for your reviewers

@dundee dundee requested a review from a team as a code owner December 5, 2024 13:03
@dundee dundee force-pushed the dundee/feat/dev-reader-errors branch from eaaa9b3 to 986e35b Compare December 5, 2024 13:04
@dundee dundee force-pushed the dundee/feat/dev-reader-errors branch from 986e35b to 0087fc8 Compare December 5, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant