feat!(rm-cause): causes are harmful #620
Draft
+2
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is demented. It produces messages like the folliowing
(irrelvant fields redacted):
In order to query this, you end up writing statements like
error.cause.cause.cause.cause.message
There's no point in that. All of our tools also support "in" queries,
so you can just check
if "context cancelled" in error.error
(error.error) is also semantically problematic, buit whatvs.
All this does is inflate our log volume and increase meaninglessly the
number of columns in honeycomb queries.
Remove it and profit.
NB: this is a scorched earch approach. Anyone updating would be
immediately su bject to this new behavior, and it might break alerting
if someone was specifically looking for the 5th cause or something goofy
like that.
Please read CONTRIBUTING.md for additional information on contributing to this repository!
What this PR does / why we need it
Jira ID
[XX-XX]
Notes for your reviewers