Finish migration to pyproject.toml
#37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
venthur
commented
Sep 18, 2023
venthur
commented
- Removed setup.py and setup.cfg -- all their contents has been moved to pyproject toml.
- don't use poetry but standard setuptools, we were not using any of poetries features so we can get rid of that dependency
- put dev-dependencies into pyproject.toml and use that via pip install -e .[dev] instead of manually listing dependencies in github actions
* Removed setup.py and setup.cfg -- all their contents has been moved to pyproject toml. * don't use poetry but standard setuptools, we were not using any of poetries features so we can get rid of that dependency * put dev-dependencies into pyproject.toml and use that via pip install -e .[dev] instead of manually listing dependencies in github actions
justinmayer
changed the title
pyproject.toml
justinmayer
approved these changes
Apr 17, 2024
.github/workflows/main.yml
Outdated
| @@ -46,7 +45,7 @@ jobs: | |||
| - name: Check release | |||
| id: check_release | |||
| run: | | |||
| python -m pip install poetry githubrelease httpx==0.18.2 autopub twine wheel | |||
| python -m pip install -e .[dev] | |||
There was a problem hiding this comment.
The general concept behind this makes sense and is an improvement in the test job, but for deployment I think it's better to install autopub[github] directly via the deploy job because these packages are only useful in the CI environment — there is no reason for individual developers to have these packages installed on their respective workstations.
|
All good! Thanks for maintaining feedgenerator! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.