Make build reproducible by reading envvar SOURCE_DATE_EPOCH if set
#3430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vincent-C
force-pushed
the
reproducible_builds
branch
from
6ed6730 to
e52b20f
Compare
justinmayer
changed the title
SOURCE_DATE_EPOCH if set
justinmayer
requested changes
Jan 15, 2025
| year = datetime.datetime.now().date().year | ||
| year = datetime.datetime.utcfromtimestamp( | ||
| int(os.environ.get("SOURCE_DATE_EPOCH", time.time())) | ||
| ).year |
There was a problem hiding this comment.
This change yields the following deprecation warning:
DeprecationWarning:
datetime.datetime.utcfromtimestamp()is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC:datetime.datetime.fromtimestamp(timestamp, datetime.UTC)
Perhaps the following instead?
year = datetime.datetime.fromtimestamp(
int(os.environ.get("SOURCE_DATE_EPOCH", time.time())), datetime.timezone.utc
).yearSee also:
justinmayer
approved these changes
Jan 15, 2025
|
I just released Pelican 4.11.0, which includes the changes in this pull request. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the ongoing Reproducible Builds project, packages in Debian/Ubuntu are routinely scanned and tested for build reproducibility. A bug was filed against the
pelicanpackage in Debian, so I'm just forwarding the patch that we've applied there to make it build reproducibly, i.e. by attempting to get the current datetime from a standard envvar, SOURCE_DATE_EPOCH, if it's available. Thanks for considering this change!