Calculate the version correctly when releasing from tag #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the last release of Porter Core there was an issue where the pipeline published the canary version instead of the finalized released. This happens because the build scripts calculate the version incorrectly when multiple tags are present on the same commit. The release process of the operator is slightly different, but updating the magefiles dependencies should ensure that the same issue is not appearing when the operator is released.
kichristensen
requested review from
schristoff,
sgettys,
bdegeeter and
troy0820
as code owners
troy0820
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
During the last release of Porter Core there was an issue where the pipeline published the canary version instead of the finalized released. This happens because the build scripts calculate the version incorrectly when multiple tags are present on the same commit.
The release process of the operator is slightly different, but updating the magefiles dependencies should ensure that the same issue is not appearing when the operator is released.
Notes for the reviewer
Checklist