Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest operator docs during netlify build #1975

Merged
merged 6 commits into from
Mar 18, 2022

Conversation

carolynvs
Copy link
Member

What does this change

Netlify caches the contents of the directory, so that it can avoid redownloading stuff each time. Our operator clone is being cached and we are ending up with stale content. This updates the operator repo before building the docs so that it has the latest content.

What issue does it fix

Part of getporter/operator#45

Notes for the reviewer

N/A

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

Netlify caches the contents of the directory, so that it can avoid
redownloading stuff each time. Our operator clone is being cached and we
are ending up with stale content. This updates the operator repo before
building the docs so that it has the latest content.

This also:
* Updates netlify to use mage instead of make
* Removes the unused make target for docs

Signed-off-by: Carolyn Van Slyck <[email protected]>
Go is sneaky and sometimes modifies local files (like adding in the
extra Go 1.17 +build tag) which causes pull to fail. This grabs the
latest for the branch and then does a hard reset to it, undoing any
local changes and avoiding errors.

Signed-off-by: Carolyn Van Slyck <[email protected]>
Signed-off-by: Carolyn Van Slyck <[email protected]>
Signed-off-by: Carolyn Van Slyck <[email protected]>
write some tests for my build scripts

Signed-off-by: Carolyn Van Slyck <[email protected]>
@carolynvs carolynvs merged commit f09fe2b into getporter:release/v1 Mar 18, 2022
@carolynvs carolynvs deleted the fix-netlify-cache branch March 18, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants