Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameter set name table output format of parameters #3314

Merged
merged 7 commits into from
Jan 31, 2025
Merged

Add parameter set name table output format of parameters #3314

merged 7 commits into from
Jan 31, 2025

Conversation

kichristensen
Copy link
Contributor

What does this change

  • Add "PARAMETER SET" column to distinguish between parameter set name and parameter name
  • Rename internal variable from paramsSets to result for clarity
  • Include parameter set name in output rows for better identification
  • Update table headers to reflect new column structure

What issue does it fix

Closes #3313

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

kichristensen and others added 2 commits January 9, 2025 14:32
@kichristensen
fix(parameters): improve parameter set table output format
1c8afb4 
- Add "PARAMETER SET" column to distinguish between parameter set name and parameter name
- Rename internal variable from paramsSets to result for clarity
- Include parameter set name in output rows for better identification
- Update table headers to reflect new column structure

Signed-off-by: Kim Christensen <[email protected]>
@kichristensen
Merge branch 'main' into showParamSet
ce8fabf
@kichristensen kichristensen changed the title Improve parameter set table output format Add parameter set name table output format of parameters Jan 20, 2025
@kichristensen kichristensen marked this pull request as ready for review January 20, 2025 15:58
troy0820
troy0820 approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@troy0820 troy0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Failing website thing though

@kichristensen kichristensen merged commit 38f22e0 into getporter:main Jan 31, 2025
45 checks passed
@kichristensen kichristensen deleted the showParamSet branch January 31, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troy0820 troy0820 troy0820 approved these changes

@schristoff schristoff Awaiting requested review from schristoff schristoff is a code owner

@sgettys sgettys Awaiting requested review from sgettys sgettys is a code owner

@bdegeeter bdegeeter Awaiting requested review from bdegeeter bdegeeter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

porter parameters list doesn't show what parameter set the parameter belongs to
2 participants
@kichristensen @troy0820