Show an error message on "Test Connection" failure for Google Spreadsheet Query Runner #6652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heet Query Runner
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6652 +/- ##
==========================================
+ Coverage 62.39% 62.57% +0.18%
==========================================
Files 161 161
Lines 13179 13184 +5
Branches 1796 1797 +1
==========================================
+ Hits 8223 8250 +27
+ Misses 4672 4649 -23
- Partials 284 285 +1
|
konnectr
approved these changes
Dec 9, 2023
|
@konnectr Thanks for reviewing! I am going to merge this. |
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Jan 8, 2025
…heet Query Runner (getredash#6652)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
This PR is for showing an error message on "Test Connection" failure for Google Spreadsheet Query Runner. In addition to that, logging a traceback for an error by redash-worker.
How is this tested?
Related Tickets & Documents
Closes #6636
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
When a service account for Google Spreadsheet is disabled
Error message on Test Connection Failure
Logs on Test Connection Failure
When a connection is refused and so on
Error message on Test Connection Failure
Logs on Test Connection Failure