Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deprecate --use-artifact-bundle option #2349

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −3
Open

feat: Deprecate --use-artifact-bundle option #2349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/commands/sourcemaps/upload.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,14 +224,14 @@ pub fn make_command(command: Command) -> Command {
uploaded.",
),
)
// NOTE: Hidden until we decide to expose it publicly
.arg(
Arg::new("use_artifact_bundle")
.long("use-artifact-bundle")
.action(ArgAction::SetTrue)
.help(
"Use new Artifact Bundles upload, that enables the use of Debug IDs \
for Source Maps discovery.",
"[DEPRECATED] Force artifact bundles to be used for upload, even when not \
supported by the server. This option has always only been intended for \
internal use, and it is now officially deprecated.",
)
.hide(true),
)
Expand Down Expand Up @@ -429,6 +429,9 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
if matches.get_flag("use_artifact_bundle")
|| env::var("SENTRY_FORCE_ARTIFACT_BUNDLES").ok().as_deref() == Some("1")
{
log::warn!("The --use-artifact-bundle option and the SENTRY_FORCE_ARTIFACT_BUNDLES environment variable \
are both deprecated, and both will be removed in the next major version.");

if let Some(ref mut options) = chunk_upload_options {
if !options.supports(ChunkUploadCapability::ArtifactBundles) {
options.accept.push(ChunkUploadCapability::ArtifactBundles);
Expand Down
Loading