Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Build visionOS project with static Sentry SDK #4462

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

brustolin
Copy link
Contributor

📜 Description

We need to enable Swift interoperability with c++ for our visionOS SDK, in order to make the static SDK work with visionOS projects

💡 Motivation and Context

Close #3809

💚 How did you test it?

External sample

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

Copy link

github-actions bot commented Oct 21, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1222.57 ms 1246.35 ms 23.78 ms
Size 21.90 KiB 708.45 KiB 686.55 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d6ff82c 1219.06 ms 1244.31 ms 25.24 ms
7f720fb 1230.00 ms 1239.63 ms 9.63 ms
2deb275 1224.04 ms 1239.37 ms 15.33 ms
86ed0eb 1229.19 ms 1250.82 ms 21.62 ms
7e8d5fd 1208.69 ms 1228.14 ms 19.45 ms
9fef8d1 1236.12 ms 1252.41 ms 16.29 ms
7cd187e 1243.56 ms 1250.20 ms 6.64 ms
b2f82fa 1237.78 ms 1256.02 ms 18.24 ms
8b1c6a9 1224.33 ms 1245.04 ms 20.72 ms
28333b6 1186.29 ms 1225.18 ms 38.89 ms

App size

Revision Plain With Sentry Diff
d6ff82c 21.58 KiB 616.14 KiB 594.56 KiB
7f720fb 21.58 KiB 709.05 KiB 687.47 KiB
2deb275 21.58 KiB 681.72 KiB 660.14 KiB
86ed0eb 21.58 KiB 542.38 KiB 520.80 KiB
7e8d5fd 20.76 KiB 435.50 KiB 414.74 KiB
9fef8d1 21.58 KiB 650.82 KiB 629.24 KiB
7cd187e 20.76 KiB 401.65 KiB 380.89 KiB
b2f82fa 20.76 KiB 419.62 KiB 398.86 KiB
8b1c6a9 21.58 KiB 706.97 KiB 685.39 KiB
28333b6 20.76 KiB 424.69 KiB 403.93 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

visionOS app fails to build with latest Sentry version, previously succeeded
2 participants