Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove runtox.sh #3587

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Remove runtox.sh #3587

wants to merge 2 commits into from

Conversation

antonpirker
Copy link
Member

The functionality of runtox.sh can be also done with tox -f so I will remove the shell script to simplify things.

Copy link

codecov bot commented Sep 30, 2024

❌ 449 Tests Failed:

Tests completed Failed Passed Skipped
29430 449 28981 5316
View the top 3 failed tests by shortest run time
 tests.integrations.arq.test_arq
Stack Traces | 0s run time
No failure message available
 tests.integrations.grpc.test_grpc
Stack Traces | 0s run time
No failure message available
 tests.integrations.starlette.test_starlette
Stack Traces | 0s run time
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@antonpirker
Copy link
Member Author

There is one problem with this: We group different frameworks together in one YAML file (like all database integrations) and those integrations need different Python versions to test on. The YAML has specified a union of all the Python verisons needed.

When we run tox -f for a Python version and framework combination that is not specified in tox.ini then the tox command fails with the same exit code then it would when the test are run but failing. So we can not decide on that level if the Github actions failed or succeeded (meaning no tests to run, continue).

So I will park this PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant