ref(grouping): Call _save_aggregate_new when feature flag enabled

[lobsterkatie]

This PR is a step towards updating the logic of _save_aggregate. The new logic will be contained in a separate function, so as a first step, this PR creates the new function, with identical logic to _save_aggregate. That way, when changes are made, they'll be starting from the same baseline as they would be were _save_aggregate itself being modified, which should hopefully make reviewing easier. It also switches to calling this new function in the flag-on branch of assign_event_to_group.

Finally, to make sure that everything still works as expected, the assign_event_to_group tests have been modified to now run both branches, flag on and flag off.

[sentry-io]

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/sentry/event_manager.py

Function	Unhandled Issue
_save_aggregate	UnableToAcquireLock: Unable to acquire <Lock: 'grouping-update-lock:61797'> due to error: Could not set key: 'l:groupi... ... Event Count: 1

---

_{Did you find this useful? React with a 👍 or 👎}

[JoshFerge]

nit: it would be nice if you linked the PR this was stacked on top of, since GH's UI is not the best for navigating these

[lobsterkatie]

nit: it would be nice if you linked the PR this was stacked on top of, since GH's UI is not the best for navigating these

Sorry - hadn't yet linked them all in the epic: #61661

(You'll notice I'm being super step-by-step-y with these changes. I really don't want to break ingestion.)

[wedamija]

Is the eventual goal here to remove the existing save_aggregate and rename this new one?

[lobsterkatie]

Is the eventual goal here to remove the existing save_aggregate and rename this new one?

Indeed.

Well, actually, that's a lie. Once the old version is gone, all of the logic from _save_aggregate_new can just move into assign_event_to_group. That currently just picks which version of _save_aggregate to call, and it will just become a pass-through once the original _save_aggregate is gone.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a1ae836) 81.40% compared to head (92c5d00) 81.40%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #64851      +/-   ##
==========================================
- Coverage   81.40%   81.40%   -0.01%     
==========================================
  Files        5251     5251              
  Lines      232145   232145              
  Branches    45581    45581              
==========================================
- Hits       188987   188972      -15     
- Misses      37276    37285       +9     
- Partials     5882     5888       +6     

see 7 files with indirect coverage changes

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ KeyError: 'event_metadata' pytest.runtest.protocol tests/sentry/tasks/test... View Issue
• ‼️ KeyError: 'event_metadata' pytest.runtest.protocol tests/sentry/tasks/test... View Issue
• ‼️ KeyError: 'event_metadata' pytest.runtest.protocol tests/sentry/tasks/test... View Issue
• ‼️ KeyError: 'event_metadata' pytest.runtest.protocol tests/integration/test_... View Issue
• ‼️ KeyError: 'event_metadata' pytest.runtest.protocol tests/sentry/integratio... View Issue

_{Did you find this useful? React with a 👍 or 👎}