Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instr(pdb): Upgrade warning to error #1614

Merged
merged 1 commit into from
Feb 5, 2025
Merged

instr(pdb): Upgrade warning to error #1614

merged 1 commit into from
Feb 5, 2025

Conversation

jjbayer
Copy link
Member

@jjbayer jjbayer commented Feb 5, 2025

Temporarily update warning about .NET with Windows PDB to an error so we can aggregate by request.scope on the sentry error to see how many projects are affected.

ref: getsentry/symbolic#871

#skip-changelog

@jjbayer jjbayer requested review from a team and loewenheim February 5, 2025 08:48
Copy link
Member

@Dav1dde Dav1dde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we instead have a metric for this?

@jjbayer
Copy link
Member Author

jjbayer commented Feb 5, 2025

Should we instead have a metric for this?

@Dav1dde I want to enumerate the projects that are affected. Currently we're seeing this warning in our logs ~1000 / day, so volume should be manageable.

@Dav1dde
Copy link
Member

Dav1dde commented Feb 5, 2025

@jjbayer 👍 I assume the project id gets added through the context/scope from the caller?

@jjbayer
Copy link
Member Author

jjbayer commented Feb 5, 2025

I assume the project id gets added through the context/scope from the caller?

Yes, configure_scope attaches tags to the sentry scope

object_handle.configure_scope();
let ppdb_obj = match object_handle.object() {
Object::PortablePdb(ppdb_obj) => ppdb_obj,
_ => {
tracing::error!("Trying to symbolicate a .NET event with a non-PPDB object file");

and the "scope" tag contains the project ID IIUC:

impl ConfigureScope for ObjectHandle {
fn to_scope(&self, scope: &mut ::sentry::Scope) {
self.object_id.to_scope(scope);
scope.set_tag("object_file.scope", &self.scope);

@jjbayer jjbayer merged commit 298e8fb into master Feb 5, 2025
16 checks passed
@jjbayer jjbayer deleted the instr/pdb-error branch February 5, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants