Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename deadletter_at -> remove_at #130

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Conversation

markstory
Copy link
Member

The name deadletter_at was a bit misleading as activations past this
deadline were not always deadlettered. Based on an activation's retry
policy they could be discarded as well.

Refs #117

The name deadletter_at was a bit misleading as activations past this
deadline were not always deadlettered. Based on an activation's retry
policy they could be discarded as well.

Refs #117
@markstory markstory requested a review from a team as a code owner January 17, 2025 18:48
@markstory markstory linked an issue Jan 17, 2025 that may be closed by this pull request
Copy link
Member

@enochtangg enochtangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@markstory markstory merged commit ed2795f into main Jan 20, 2025
10 checks passed
@markstory markstory deleted the fix-117-rename-deadletterat branch January 20, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename inflight_taskactivations.deadletter_at
2 participants