Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change to use pnpm #45 #46

Merged
merged 8 commits into from
Aug 29, 2023
Merged

change to use pnpm #45 #46

merged 8 commits into from
Aug 29, 2023

Conversation

minhphuc010194
Copy link
Member

No description provided.

@minhphuc010194 minhphuc010194 self-assigned this Aug 28, 2023
@minhphuc010194 minhphuc010194 linked an issue Aug 28, 2023 that may be closed by this pull request
@vercel
Copy link

vercel bot commented Aug 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextjs-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2023 6:33am

};

export const TextEditor: FC<PropTypes> = ({ value, onSave }) => {
export const TextEditor: FC<PropTypes> = ({ value, onChange }) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anh khuyến khích là dùng onSubmit hay onSave hoặc cái gì đó tương đương, onChange sẽ dễ bị hiểu lầm là event này fired với mọi ký tự (như cách mà input's onChange hoạt động.

Copy link
Member Author

@minhphuc010194 minhphuc010194 Aug 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Em đang chuyển qua onChange đúng với ngữ cảnh của nó á anh, em tính chuyển nút save ra bên ngoài! em dùng onSave nhưng khi bấm onSave của thằng tinymce thì nó ko cập nhật đc state hiện tại bên ngoài vào trong func!

@minhphuc010194 minhphuc010194 changed the title pending issue - change to use pnpm #45 change to use pnpm #45 Aug 28, 2023
package.json Outdated
@@ -35,7 +35,8 @@
"react-dom": "18.2.0",
"react-icons": "4.10.1",
"react-virtuoso": "4.5.0",
"swr": "2.2.1"
"swr": "2.2.1",
"tinymce": "^6.6.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Install nhớ dùng -E để không có cái tidal ^

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sr anh! em lại quên :/

@@ -39,7 +39,7 @@ CREATE TABLE "User" (
-- CreateTable
CREATE TABLE "Post" (
"id" TEXT NOT NULL,
"title": TEXT,
"title" TEXT,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ủa tại sao lại sửa cái này???

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file migrations được tạo ra tự động từ prisma, và trong 99,99% trường hợp mình không sửa nó bằng tay, vì sau này nó rất dễ conflict với tables trong database

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cái title: TEXT em viết sai cú pháp nên em sửa lại á! Mà chắc em xoá cái đó cho chắc! hôm bữa em thêm vô thử xem nó chạy thế nào ^ ^!

@minhphuc010194 minhphuc010194 merged commit e900810 into master Aug 29, 2023
2 checks passed
@minhphuc010194 minhphuc010194 deleted the 45-change-to-use-pnpm branch September 12, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change to use pnpm
2 participants