Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added jotai provider #86

Merged
merged 1 commit into from
Sep 13, 2023
Merged

added jotai provider #86

merged 1 commit into from
Sep 13, 2023

Conversation

sangdth
Copy link
Member

@sangdth sangdth commented Sep 12, 2023

close #84

@vercel
Copy link

vercel bot commented Sep 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextjs-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2023 9:25am

minhphuc010194
minhphuc010194 previously approved these changes Sep 13, 2023
Copy link
Member

@minhphuc010194 minhphuc010194 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@minhphuc010194 minhphuc010194 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🚀

{children}
</ChakraProvider>
</CacheProvider>
<JotaiProvider>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sao mình thay đổi vị trí thằng JotailProvider vô giữa thằng CacheProvider và thằng SessionProvider anh Sang?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anh muốn Jotai states thấy được Session, trong một số trường hợp mình không cho user query nhiều, ví dụ bài blogs, người không đăng nhập vẫn query được hết, nhưng người đăng nhập maybe có thể query thêm sâu hơn (admin chẳng hạn). Khi JotaiProvider nằm bên dưới Session thì nó có thể nhận được.

@sangdth sangdth merged commit 715d4a6 into master Sep 13, 2023
2 checks passed
@sangdth sangdth deleted the add-jotai-provider branch September 13, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sometimes see warning with jotai
2 participants