Customizable menu icon #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will use them later. The icon-name property shall select the icon used in the menu button, while the icon-symbolic property determines whether the icon will be used in its symbolic or default variant.
The actual icon can now be changed via the icon-name gsettings key. By default, the applet will load a symbolic version of the icon. This behavior can be changed via the icon-symbolic key. Changes to any of these keys should directly be visible. Fixes: getsolus#48
|
Hi! I packaged your fork for OpenSUSE (Leap 15.6 and Tumbleweed)! Thank you for your work! :D https://build.opensuse.org/package/show/home:asdhio/brisk-menu |
|
I didn't know Ermo was going to ping Ikey about this. |
|
Gonna look properly later today, not sure re special casing of symbolics, or using equality check on null pointers ^^ |
Any progress? ^^ |
|
This patch is now included in the OpenSUSE Tumbleweed package and will be included in OpenSUSE Leap 16. |
|
@ikeycode ping to ensure you see this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #48, here follows the implementation of making the menu icon customizable and modifiable at run time.
This implementation adds two new keys to the gsettings schema:
icon-namewhich can be used to select the base iconicon-symbolicwhich is a toggleable boolean switch selecting whether the symbolic icon variant shall be shown in the menu.I went with that because we actually have to change two icons - the menu icon itself and the icon displayed in the about dialog. The old behavior was to use the symbolic variant of the icon in the menu and the non-symbolic, full-color variant in the about dialog, which generally makes sense, but I can see how some people would like to use a non-symbolic, full-color variant for the menu icon as well.