Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weekly flatpak GHA is now failing #1184

Closed
SqAtx opened this issue Feb 3, 2025 · 2 comments · Fixed by #1187
Closed

Weekly flatpak GHA is now failing #1184

SqAtx opened this issue Feb 3, 2025 · 2 comments · Fixed by #1187
Labels
packaging Flatpak packages (anything else = NOPE.png) regression Essential features that recently broke

Comments

@SqAtx
Copy link
Contributor

SqAtx commented Feb 3, 2025

Nope it's not #1179 - this failure is earlier.

Consider https://github.com/getting-things-gnome/gtg/actions/workflows/weekly_flatpak.yml - the last build has failed with

Error: Build failed: Error: Create Artifact Container failed: The artifact name org.gnome.GTG.Devel-x86_64 is not valid. Request URL https://pipelinesghubeus25.actions.githubusercontent.com/zwKedJ2Og21aFWNNc1WYkO8aLQ4SnVANM1rxDhvkcoWu0Y3tTk/_apis/pipelines/workflows/13064705578/artifacts?api-version=6.0-preview

Every previous build happily produced an artifact with that name - the last one is https://github.com/getting-things-gnome/gtg/actions/runs/12941536682

GitHub might have changed their rules regarding what is a valid name.
@SqAtx SqAtx added the regression Essential features that recently broke label Feb 3, 2025
This was referenced Feb 3, 2025
Merged
Open
@SqAtx
Copy link
Contributor Author

SqAtx commented Feb 9, 2025

The root cause is https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/:

Starting January 30th, 2025, GitHub Actions customers will no longer be able to use v3 of actions/upload-artifact or actions/download-artifact.

We're using upload-artifact from flatpak-github-actions, and the issue has been filed there as flatpak/flatpak-github-actions#214. flatpak/flatpak-github-actions#184 is expected to fix that, but the associated PR flatpak/flatpak-github-actions#198 hasn't been merged.

The GHA has been forked at https://github.com/flathub-infra/flatpak-github-actions, and the issue was fixed there back in July: flathub-infra/flatpak-github-actions@efb7f71 Maybe we should just use that. I'll experiment.

SqAtx added a commit to SqAtx/gtg that referenced this issue Feb 9, 2025
@SqAtx
Use flathub-infra/flatpak-github-actions/ to build weekly flatpak
879278f 
Fixes getting-things-gnome#1184

Our current `flatpak/flatpak-github-actions` is not longer working,
because it is using a deprecated version of the `upload-artifact` GHA.
From
https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/:

> Starting January 30th, 2025, GitHub Actions customers will no longer
> be able to use v3 of https://github.com/actions/upload-artifact or
> https://github.com/actions/download-artifact.

We're using upload-artifact from flatpak-github-actions, and the issue
has been filed there as
flatpak/flatpak-github-actions#214.
flatpak/flatpak-github-actions#184 is expected
to fix that, but the associated PR
flatpak/flatpak-github-actions#198 hasn't been
merged.

The GHA has been forked at
https://github.com/flathub-infra/flatpak-github-actions, and the issue
was fixed there back in July:
flathub-infra/flatpak-github-actions@efb7f71

So let's switch to that. I don't like that it's not versioned and we
need to use the master branch, which may add breaking changes at any
time. But it's better than our current solution, which can no longer
work.

Tested on a fork, and the artifact is created correctly.
@SqAtx SqAtx added the packaging Flatpak packages (anything else = NOPE.png) label Feb 9, 2025
SqAtx added a commit to SqAtx/gtg that referenced this issue Feb 9, 2025
@SqAtx
Use flathub-infra/flatpak-github-actions/ to build weekly flatpak
0b6f4b5 
Fixes getting-things-gnome#1184

Our current `flatpak/flatpak-github-actions` is not longer working,
because it is using a deprecated version of the `upload-artifact` GHA.
From
https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/:

> Starting January 30th, 2025, GitHub Actions customers will no longer
> be able to use v3 of https://github.com/actions/upload-artifact or
> https://github.com/actions/download-artifact.

We're using upload-artifact from flatpak-github-actions, and the issue
has been filed there as
flatpak/flatpak-github-actions#214.
flatpak/flatpak-github-actions#184 is expected
to fix that, but the associated PR
flatpak/flatpak-github-actions#198 hasn't been
merged.

The GHA has been forked at
https://github.com/flathub-infra/flatpak-github-actions, and the issue
was fixed there back in July:
flathub-infra/flatpak-github-actions@efb7f71

So let's switch to that. I don't like that it's not versioned and we
need to use the master branch, which may add breaking changes at any
time. But it's better than our current solution, which can no longer
work.

Tested on a fork, and the artifact is created correctly:
https://github.com/SqAtx/gtg/actions/runs/13222384044
@SqAtx SqAtx mentioned this issue Feb 9, 2025
Merged
@SqAtx
Copy link
Contributor Author

SqAtx commented Feb 16, 2025

OK this week's GHA run was successful https://github.com/getting-things-gnome/gtg/actions/runs/13320709229

The flatpak itself isn't working, but that's #1179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
packaging Flatpak packages (anything else = NOPE.png) regression Essential features that recently broke
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use flathub-infra/flatpak-github-actions/ to build weekly flatpak SqAtx/gtg
1 participant
@SqAtx