Use flathub-infra/flatpak-github-actions/ to build weekly flatpak #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes getting-things-gnome#1184 Our current `flatpak/flatpak-github-actions` is not longer working, because it is using a deprecated version of the `upload-artifact` GHA. From https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/: > Starting January 30th, 2025, GitHub Actions customers will no longer > be able to use v3 of https://github.com/actions/upload-artifact or > https://github.com/actions/download-artifact. We're using upload-artifact from flatpak-github-actions, and the issue has been filed there as flatpak/flatpak-github-actions#214. flatpak/flatpak-github-actions#184 is expected to fix that, but the associated PR flatpak/flatpak-github-actions#198 hasn't been merged. The GHA has been forked at https://github.com/flathub-infra/flatpak-github-actions, and the issue was fixed there back in July: flathub-infra/flatpak-github-actions@efb7f71 So let's switch to that. I don't like that it's not versioned and we need to use the master branch, which may add breaking changes at any time. But it's better than our current solution, which can no longer work. Tested on a fork, and the artifact is created correctly: https://github.com/SqAtx/gtg/actions/runs/13222384044
|
We can keep an eye on the original GHA and go back to it when they release a v7 that works :) |
TheEvilSkeleton
approved these changes
Feb 9, 2025
TheEvilSkeleton
added a commit
to TheEvilSkeleton/Bottles
that referenced
this pull request
Feb 9, 2025
TheEvilSkeleton
added a commit
to TheEvilSkeleton/Bottles
that referenced
this pull request
Feb 9, 2025
TheEvilSkeleton
added a commit
to bottlesdevs/Bottles
that referenced
this pull request
Feb 9, 2025
diegogangl
added this to the 0.7: "Getting things Gradius — Destroy the core!" milestone
|
Sounds like a good solution for now, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1184
Our current
flatpak/flatpak-github-actionsis not longer working, because it is using a deprecated version of theupload-artifactGHA. Fromhttps://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/:
We're using upload-artifact from flatpak-github-actions, and the issue has been filed there as
flatpak/flatpak-github-actions#214. flatpak/flatpak-github-actions#184 is expected to fix that, but the associated PR
flatpak/flatpak-github-actions#198 hasn't been merged.
The GHA has been forked at
https://github.com/flathub-infra/flatpak-github-actions, and the issue was fixed there back in July:
flathub-infra/flatpak-github-actions@efb7f71
So let's switch to that. I don't like that it's not versioned and we need to use the master branch, which may add breaking changes at any time. But it's better than our current solution, which can no longer work.
Tested on a fork, and the artifact is created correctly: https://github.com/SqAtx/gtg/actions/runs/13222384044