Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show parent's title & children count in "Open Parent" button tooltip #1030

Conversation

nekohayo
Copy link
Member

@nekohayo nekohayo commented Feb 28, 2024

This allows checking at a glance if the current task blocks a project:

Screenshot from 2024-02-28 02-34-09

Screenshot from 2024-02-28 02-02-19

Screenshot from 2024-02-28 02-02-34

Fixes #1027


Potentially, I could maybe also add another commit on top that recursively counts how many parent levels there are, and adds an extra line to say something like:

In total, %d parent tasks are blocked by the current task.

…what do you think, would that extra info be helpful too, or too much?

Copy link
Contributor

@diegogangl diegogangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, save one nitpick.

GTG/gtk/editor/editor.py Outdated Show resolved Hide resolved
@nekohayo nekohayo marked this pull request as draft March 1, 2024 06:07
@nekohayo nekohayo self-assigned this Mar 1, 2024
This allows checking at a glance if the current task blocks a project.

Fixes getting-things-gnome#1027
@nekohayo nekohayo force-pushed the detailed_tooltip_for_open_parent_button branch from 5481b77 to 202711f Compare April 7, 2024 19:20
@nekohayo nekohayo marked this pull request as ready for review April 7, 2024 19:22
@nekohayo nekohayo requested a review from diegogangl April 7, 2024 19:22
@diegogangl diegogangl merged commit 1b95fe1 into getting-things-gnome:master Apr 11, 2024
1 check passed
@diegogangl
Copy link
Contributor

Looks good!

@nekohayo nekohayo deleted the detailed_tooltip_for_open_parent_button branch May 23, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preview the parent task's title summary with a tooltip on the "Open Parent" button in the Task Editor
2 participants