Fix check for empty excerpts in popups #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the content had some whitespace the if-guard would fail, creating a tooltip with just "...". It would also fail because it would include tags and subtasks. So now we first process the content properly and then check. fixes getting-things-gnome#1010
diegogangl
added this to the 0.7: "Getting things Gradius — Destroy the core!" milestone
SqAtx
reviewed
Apr 20, 2024
There was a problem hiding this comment.
The change itself looks good to me.
If the content had some whitespace the if-guard would fail, creating a tooltip with just "...".
It would also fail because it would include tags and subtasks. So now we first process the content properly and then check.Also fixes the regex to remove tags in a comma list properly from the excerpt
Could we add tests for these cases? Ideally break the existing test_excerpt() into one test for each case (empty task, task with only whitespace, test that tags are ignored, etc)
This type of functionality is just perfect for unit tests: it's just text in / text out.
|
Good idea, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the content had some whitespace the if-guard would fail, creating a tooltip with just "...".
It would also fail because it would include tags and subtasks. So now we first process the content properly and then check.
Also fixes the regex to remove tags in a comma list properly from the excerpt
fixes #1010