Fix alignment in hierarchical views #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leverage GtkTreeExpander's ability to handle indentation both for tags in the sidebar and tasks in the task list. Create a children_count property for the Tag class so that the expander can bind to it. This fixes GitHub issue getting-things-gnome#1042
|
Great work, this feels much better and the code leans on bindings so we won't have all those issues with interface updates. |
diegogangl
added this to the 0.7: "Getting things Gradius — Destroy the core!" milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1042
The new code leverages
GtkTreeExpander's ability to handle indentation both for tags in the sidebar and tasks in the task list. I also created achildren_countproperty for the Tag class so that the expander can bind to it.