Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix appdata related issues #1096

Merged
merged 1 commit into from
May 13, 2024

Conversation

yakushabb
Copy link
Contributor

@yakushabb yakushabb commented May 2, 2024

  • Add missing developer block
  • Update homepage to github page, due to the wiki page are going to be retired.
  • Add vcs-browser URL
  • Update translation URL
  • Remove the none aors rules
  • Fix the updatecontact tag
  • Copy screenshots to the repository

@diegogangl
Copy link
Contributor

Thanks for working on this! Everything looks good. One thing we should discuss is how often we expect screenshots to change. If they don't, then it makes some sense to have them in the repo, otherwise I would keep them in a server/wiki to avoid ballooning the repo with binary data.

What do you think @nekohayo ?

@yakushabb
Copy link
Contributor Author

GNOME wiki pages are going to be retired.

Old screenshots links seem not working.

resim

resim

@diegogangl
Copy link
Contributor

Yes, but we could put them in this repo's wiki:
https://github.blog/changelog/2022-02-14-upload-images-to-wiki-pages/

@yakushabb
Copy link
Contributor Author

If you kindly provide URLs, I can update them. It seems that 'gtg' does not have a wiki page on GitHub.

@diegogangl
Copy link
Contributor

While trying it, it seems we can't control the urls of the images we post. I wonder if @nekohayo would mind hosting the images? Otherwise we can put them in git lfs

@Neui
Copy link
Contributor

Neui commented May 6, 2024

You can clone a git wiki repo on the wiki page, does commiting images there and pushing them work?

@yakushabb
Copy link
Contributor Author

I really have no idea how to commit a wiki page on GitHub.

I suppose providing an image URL should work for AppData.

@diegogangl
Copy link
Contributor

Thanks for tip @Neui !
@yakushabb Sorry for the wait, here are the urls:

https://raw.githubusercontent.com/wiki/getting-things-gnome/gtg/assets/screenshots/0.6/main_with_background.png
https://raw.githubusercontent.com/wiki/getting-things-gnome/gtg/assets/screenshots/0.6/main_window.png
https://raw.githubusercontent.com/wiki/getting-things-gnome/gtg/assets/screenshots/0.6/detail.png

- Add missing developer block
- Update homepage to github page, due to the wiki page are going to be retired.
- Add vcs-browser URL
- Update translation URL
- Remove the none AORS rules
- Fix the updatecontact tag
- Update screenshots
@yakushabb
Copy link
Contributor Author

Updated.

@diegogangl diegogangl added enhancement packaging Flatpak packages (anything else = NOPE.png) labels May 13, 2024
@diegogangl diegogangl merged commit c726c4d into getting-things-gnome:master May 13, 2024
@diegogangl
Copy link
Contributor

...and merged!
Thanks for the work :)

@yakushabb yakushabb deleted the fix-appdata branch May 13, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement packaging Flatpak packages (anything else = NOPE.png)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants