Require GTK 4.10 #1103
Require GTK 4.10 #1103
Conversation
| # Check for some runtime dependencies so they are displayed with an "NO" | ||
| # when building which could give the user an idea what could be missing. | ||
| dep_glib = dependency('glib-2.0', required: false) | ||
| dep_gtk = dependency('gtk+-3.0', required: false) |
There was a problem hiding this comment.
I'm pretty sure GTK3 is no longer a dependency! Also, I think we want GtkSourceView 5, but one thing at a time.
|
Hm, GHA doesn't like this because it uses Ubuntu 22.04 and GTK 4.6... Maybe we should just check at runtime then. |
|
Why not update the action to 24.04? There are packages for Gtk 4.14 for that version |
|
Because I didn't know that GHA already had 24.04 runners =D But I was also wondering whether this should be a compile-time check. On one hand, it makes sense to fail early, and not compile something that we know won't run. On the other hand, the Ubuntu runners will eventually fall behind too much - if we want to require GTK >4.14 before 2026, we won't be able to use Ubuntu directly on GHA and do something as simple as But now that I've typed this out, I think the compile-time check makes the most sense. If/when we require a version that's not available on Ubuntu LTS, we'll adapt the GHA workflow. |
|
Ubuntu has backports: https://help.ubuntu.com/community/UbuntuBackports |
|
Hm Python 3.8 isn't available to be installed on Ubuntu 2404.04 - https://github.com/getting-things-gnome/gtg/actions/runs/9237207451/job/25413900625 I'm not sure where the limitation comes from exactly. Maybe from the Ubuntu repos. Or maybe form GitHub when they create the images from their VM. Either way, there doesn't seem to be a simple way to use a VM that has both Python 3.8 and GTK 4.10. I'd be tempted to just raise the minimum requirement to 3.9. 3.8's EOL is at the end of October, and I'm guessing we'd probably be releasing GTG 0.7 before then, so this isn't the most technically precise. But that'd be the pragmatic option. Or we could keep the minimum requirement at 3.8 nominally, and just check 3.9 on GHA. We can keep the 3.8 requirement in mind when coding, and just not check it automatically. If somebody feels strongly about being able to run GTG 0.7 on Python 3.8, we/they can do whatever backporting work is necessary then. |
Relates to getting-things-gnome#1093 GTK 4.10 has been required since getting-things-gnome@23a9868
|
I think this is a decent solution! |
|
Ah, but I just noticed that 05dc6b1 introduced a |
|
Merged, thanks! |
Relates to #1093
GTK 4.10 has been required since
23a9868
Tested by setting the requirement to 4.13, and getting