Apply simple Ruff fixes #1105
Merged
Apply simple Ruff fixes #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to getting-things-gnome#237 With one exception, this is the output of `ruff lint --fix`. The changes look minor - it mostly removes unused imports. Ruff reports a lot of other errors, including a fair amount of "Undefined name" that indicate broken code paths. We can tackle those separately, and decide whether we want to add Ruff to the pre-commit hook. This commit in itself is still a good quality of life improvement. I also did some smoke testing to make sure nothing is obviously broken.
SqAtx
commented
May 25, 2024
| @@ -165,7 +165,7 @@ def get(self, option): | |||
| if value is None and default_value is None: | |||
| raise ValueError( | |||
| 'No valid configuration value or default value was ' | |||
| 'found for %s in %s'.format(option, self._section_name)) | |||
| f'found for {option} in {self._section_name}') | |||
There was a problem hiding this comment.
Ruff originally called this a violation of string-dot-format-extra-positional-arguments (F523) and proposed to make it
'found for %s in %s'.format())
which was obviously not what the code is intended to be. The correct fix would have been
'found for {} in {}'.format(option, self._section_name))
but I figured it makes more sense to use an fstring.
diegogangl
added
enhancement
maintainability
diegogangl
added this to the 0.7: "Getting things Gradius — Destroy the core!" milestone
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #237
With one exception, this is the output of
ruff lint --fix. The changes look minor - it mostly removes unused imports.Ruff reports a lot of other errors, including a fair amount of "Undefined name" that indicate broken code paths. We can tackle those separately, and decide whether we want to add Ruff to the pre-commit hook.
This commit in itself is still a good quality of life improvement.
I also did some smoke testing to make sure nothing is obviously broken.