Fix the type hints in base_store.py #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use the _Element class instead of the Element factory for typing. - Make BaseStore generic so that subclasses can have the precise return and parameter types instead of Any. - The stored objects are required to have certain fields.
diegogangl
added
enhancement
maintainability
diegogangl
added this to the 0.7: "Getting things Gradius — Destroy the core!" milestone
|
LGTM. Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type hints could provide better maintainability. My final goal is to fix the typing of the main core components at least. I also hope to catch some bugs along the way. This PR fixes
base_store.py._Elementclass instead of theElementfactory for typing.BaseStoregeneric so that subclasses can have the precise return and parameter types instead ofAny.One can test the result using mypy:
(You might need to install the
lxml-stubspython package.)