Fixes for 'filter_tag' #1126
Merged
Fixes for 'filter_tag' #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Iterate over all tasks, not just the root elements. - Consider all descendants of a tag, not just the immediate children.
|
Looks good, merging. Thanks! |
diegogangl
added this to the 0.7: "Getting things Gradius — Destroy the core!" milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two main changes:
Because of these bugs, it was impossible to get rid of the
moneytag in the default dataset:moneytag in the sidebar.moneytag is absent from the sidebar.moneytag reappearing in the sidebar.(I discovered this bug while investigating Issue #1115. They might be related, but the described anomaly is different.)