Sort Order #1135
Merged
Sort Order #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegogangl
added this to the 0.7: "Getting things Gradius — Destroy the core!" milestone
|
Used stateful actions for the sorting menu, it's looking a lot better now
|
SqAtx
approved these changes
Sep 14, 2024
There was a problem hiding this comment.
Well you updated the review while I was looking at it ^^'
It looks a lot better now! The UI is clear and usable.
I do think we can iterate again on the UI later. I don't have concrete suggestions right now, but it seems to me that there is potential to make it a bit more compact / require fewer clicks. But yeah, very happy with how it turned out :)
Thanks to @SqAtx for the suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a couple of buttons to reverse the sorting order (ascending or descending), also converts the sorting options to stateful actions which gives us radio buttons
closes #1021