Fix calendar selection for repeating tasks #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After selecting the desired day in the yearly calendar, the _update_calendar method synced the monthly calendar, thus triggering the _on_monthly_selected callback. The bug also worked the other way around. Now, the _update_calendar blocks these callbacks to prevent the issue. Fixes GitHub issue getting-things-gnome#1015
diegogangl
added this to the 0.7: "Getting things Gradius — Destroy the core!" milestone
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1015
After selecting the desired day in the yearly calendar, the
_update_calendarmethod synced the monthly calendar, thus triggering the_on_monthly_selectedcallback. The bug also worked the other way around.Now, the
_update_calendarblocks these callbacks using awithstatement to prevent the issue.