Minor type fixes for core #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add some missing type hints - add a typing stub for core/info.py.in - introduce TMP_KEYWORDS to avoid changing types - simplify TaskTagSorter.get_first_letter to resolve a missing return error
diegogangl
added
the
maintainability
diegogangl
added this to the 0.7: "Getting things Gradius — Destroy the core!" milestone
|
LGTM, Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes are as follows:
Plugin.missing_dbusis never actually updated, maybe it can be removed once we are sure that we don't need it. The current type hint is based on an older code version.)core/info.py.in.TMP_KEYWORDSto avoid changing types.TaskTagSorter.get_first_letterto resolve a missing return error. (Based on my micro-benchmarks, it is still performant.)