Create keyboard shortcuts to switch between Open, Actionable and Closed issue#975 #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add new improviment in MainWindow, new keyboard shortcuts
Neui
reviewed
Nov 21, 2024
GTG/gtk/browser/main_window.py
Outdated
Comment on lines
135
to
138
| #switch tab | ||
| self.switch_tab_open() | ||
| self.switch_tab_actionable() | ||
| self.switch_tab_closed() |
There was a problem hiding this comment.
Why are they called here at init? I don't see the need for this.
There was a problem hiding this comment.
Upon reviewing the code as recommended, I have implemented the necessary modifications
|
I will review the code |
Upon reviewing the code as recommended, I have implemented the necessary modifications
diegogangl
added this to the 0.7: "Getting things Gradius — Destroy the core!" milestone
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created new shortcut keyboard to switch tabs. Use the commands Alt+1, Alt+2 and Alt+3 to execute the shortcuts
issue #975