Test and refactor BaseStore.unparent #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add unit tests for BaseStore.unparent - use ValueError instead of KeyError when both parameters exist but are not in a child-parent relation - simplify the algorithm
gycsaba96
force-pushed
the
test-basestore-unparent
branch
from
ec818e4 to
93be36e
Compare
diegogangl
added
enhancement
maintainability
diegogangl
added this to the 0.7: "Getting things Gradius — Destroy the core!" milestone
|
No plans or anything really, IIRC items didn't have a parent property (only children) in the very early versions of the new core. Less parameters is better though. Would you like to do it in this branch or another PR? |
- remove the parent_id argument and adjust the code accordingly - adjust the test cases - (rename some test classes to keep things consistent)
|
Let's do it in one PR. I removed the |
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added unit tests for
BaseStore.unparentand did a bit of refactoring. The only minor thing it revealed was that aKeyErrorwas raised even when both IDs existed, but the corresponding items were not in a child-parent relation.The main changes are as follows:
BaseStore.unparent,ValueErrorinstead ofKeyErrorwhen both parameters exist but are not in a child-parent relation,Note:
BaseStore.unparentdoesn't actually need theparent_idas an extra input since it can be derived aschild.parent.id. Unparenting is used in around 20 places, so the argument should be relatively easy to remove. Are there any plans or design decisions that could influence this?