Use Task.set_status to mark tasks as done or active #1183
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1180
Somehow, setting the task done was triggered twice: in
TaskEditor.change_status
and inMainWindow.on_mark_as_done
. SinceMainWindow.on_mark_as_done
also usedTask.toggle_status
, the effect was reversed.Some remarks:
set_status
triggered twice, but since fixingMainWindow.on_mark_as_done
fixes the problem, I would say it is a question for another day.MainWindow.on_dismiss_task
).