Convenience functions for adding and removing children #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegogangl
added this to the 0.7: "Getting things Gradius — Destroy the core!" milestone
|
I'm testing this with "Add Subtask" and "Add Parent Task" from the RMB menu, and it looks like the new tasks dissapear after closing the task editor? |
- introduce the StoreItem.add_child and StoreItem.remove_child methods (automatically trigger signals and potentially other functionality) - add unit tests for the methods above - leverage these methods in the BaseStore, TaskStore and TagStore
gycsaba96
force-pushed
the
add-and-remove-child
branch
from
6fdaf06 to
c0cb707
Compare
|
I rebased the branch so that it has PR #1175 in it. It seems to solve the "Add Subtask" part. Unfortunately, I can not reproduce the problem with the "Add Parent Task" option. Could you please provide more details if the bug is still there? (However, the editor does not open when the task already has a parent. But this bug was present in earlier versions as well.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation behind this PR is to simplify the cases when class A emits a signal on class B because class C did something. E.g., the
Taskclass can manage the update of itshas_childrenproperty alone. (Overriding these methods can also help realising when a task is no longer actionable.)The main changes are as follows:
StoreItem.add_childandStoreItem.remove_childmethods (automatically trigger signals and potentially other functionality)BaseStore,TaskStoreandTagStore