Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed (works for me) fix of versioning detection #933

Merged

Conversation

paulgear
Copy link
Contributor

@paulgear paulgear commented Oct 8, 2022

This is my proposed fix for the incompatibility between scripts/import_tasks_from_local.sh and the versioning decisions in versioning.py and backend_localfile.py.

Fixes #920 (hopefully).

@diegogangl
Copy link
Contributor

Hey, thanks for sticking around and submitting a fix for this! I haven't tested yet, but the code looks good (hinted, documented and all too). There's only caveat: the local backend is going away once the gtk4/newcore port lands (this pr: #894).

We could put these changes in the versioning file, or wait until the branch lands and port them over in the new datastore (which fills the roles of datastore+requester+local backend).

@paulgear
Copy link
Contributor Author

paulgear commented Oct 9, 2022

Hey, thanks for sticking around and submitting a fix for this! I haven't tested yet, but the code looks good (hinted, documented and all too). There's only caveat: the local backend is going away once the gtk4/newcore port lands (this pr: #894).

That PR says in the opening statements that it's on fire - is that still the case? I'd personally rather not track the moving target of a future version, because I want this to work for the currently-available stable version. But I have a working data file now, so my biggest barrier to getting my life back is solved. 😄

We could put these changes in the versioning file, or wait until the branch lands and port them over in the new datastore (which fills the roles of datastore+requester+local backend).

I really don't think versioning is either well-named, or an appropriate place for file operations - it's really about XML structure conversions.

I'll leave it up to you what to do with this. Once the new backend structure arrives I'm happy to help work out how to make this fit in with that.

@diegogangl diegogangl merged commit 25dfa55 into getting-things-gnome:master Oct 15, 2022
diegogangl added a commit to diegogangl/gtg that referenced this pull request Oct 22, 2022
This is my proposed fix for the incompatibility between scripts/import_tasks_from_local.sh and the versioning decisions in versioning.py and backend_localfile.py.

By Paulgear
diegogangl added a commit to diegogangl/gtg that referenced this pull request Mar 28, 2023
This is my proposed fix for the incompatibility between scripts/import_tasks_from_local.sh and the versioning decisions in versioning.py and backend_localfile.py.

By Paulgear
diegogangl added a commit that referenced this pull request Feb 19, 2024
This is my proposed fix for the incompatibility between scripts/import_tasks_from_local.sh and the versioning decisions in versioning.py and backend_localfile.py.

By Paulgear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crash when using data file from 0.3.1
3 participants