Arenassssss #142
Merged
Arenassssss #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All allocations made by either Getty or deserializer implementations will use this new arena allocator. Deserializers can, of course, have a secondary allocator for anything else they need, but all deserialized values part of the final value returned to the user by getty.deserialize should exist within this arena. This should remove the need for getty.de.free, fix the issue of not knowing what lifetime an intermediate, deserialized value has, and make things significantly easier on the error handling side since visitors and blocks don't need to free anything, they can simply return an error and getty.deserialize will deinit at the end.
Similar to struct keys, they're never needed again so might as well save some memory and free em immediately.
Lifetimes replace them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First half of #135.
Getty will still copy everything so functionally everything should be the same (aside from getting back an arena obviously). I'll update getty-json afterwards and make sure everything's okay, then we can start the optimization half of things with lifetimes.