SDK-2259:added retrieve qr code #290

mehmet-yoti · 2023-10-25T13:02:29Z

No description provided.

irotech · 2023-10-31T15:47:50Z

digitalidentity/service.go

+		return share, err
+	}
+
+	err = json.Unmarshal(responseBytes, &share)


share? This as instance of ShareSessionFetchedQrCode should be named accordinly

irotech · 2023-10-31T15:51:42Z

digitalidentity/service_test.go

+
+func TestGetQrCode(t *testing.T) {
+	key := test.GetValidKey("../test/test-key.pem")
+	mockQrId := "SOME_SESSION_ID"


SOME_QR_CODE_ID or similiar

irotech · 2023-10-31T15:53:48Z

digitalidentity/share_session_created.go

+package digitalidentity
+
+// ShareSessionCreated Share Session QR Result
+type ShareSessionCreated struct {


I don't know how GO architecture works but I'm pretty sure there is a way to reuse the response obj from the session creation

there is, but the session object here is smaller than what's returned for session created - unless the api docs are mistaken?

we have made this struct inline so i think this is now unnecessary

dunno what API u're referring to but both Session creation and QR fetch response (limited to the session) are

{ "id": "", "status": "", "expiry": "" }

where the full response for the QR fetch endpoint is

{ "id": "", "expiry": "", "policy": "", "extensions": [ ], "session": { "id": "", "status": "", "expiry": "" }, "redirectUri": "" }

would something like the below work?

type session struct { id string status string expiry string } type qr struct { id string expiry string policy string session ... }

when you fetch the session, the session resource seems to be larger than what is returned in the fetch qr code response (what you posted), we could embed it and just have it unmarshal the whole thing, but some extra fields will just be empty for the RP, imo it's better to avoid it if the API itself specifically limits the fields and not give the RP any cause for confusion or incorrect expectations.

sorry I thought I answered this but I must have not pushed the button. I meant this session created response

irotech · 2023-10-31T15:55:16Z

digitalidentity/service.go

+// Get Share QR info using the supplied sessionID
+func GetShareQr(httpClient requests.HttpClient, sessionID string, clientSdkId, apiUrl string, key *rsa.PrivateKey) (share ShareSessionFetchedQrCode, err error) {


Both the function and the comment use the wrong id. This is not the sessionId but the qrId from the qr code creation endpoint

_examples/idv/handlers.session.go

digitalidentity/share_retrieve_qr.go

digitalidentity/share_session_created.go

digitalidentity/service.go

klaidas · 2023-10-31T18:05:33Z

digital_identity_client.go

+// Get session QR code based on generated Qr ID
+func (client *DigitalIdentityClient) GetQrCode(qrCodeId string) (share digitalidentity.ShareSessionFetchedQrCode, err error) {


Suggested change

// Get session QR code based on generated Qr ID

func (client *DigitalIdentityClient) GetQrCode(qrCodeId string) (share digitalidentity.ShareSessionFetchedQrCode, err error) {

// GetShareSessionQrCode retrieves a session QR code based on generated Qr ID

func (client *DigitalIdentityClient) GetShareSessionQrCode(qrCodeId string) (share digitalidentity.ShareSessionQrCode, err error) {

might aswell keep the naming consistent "ShareSession" everywhere

klaidas · 2023-11-02T00:45:46Z

digital_identity_client.go

+// Get session QR code based on generated Qr ID
+func (client *DigitalIdentityClient) GetQrCode(qrCodeId string) (share digitalidentity.ShareSessionQrCode, err error) {


Suggested change

// Get session QR code based on generated Qr ID

func (client *DigitalIdentityClient) GetQrCode(qrCodeId string) (share digitalidentity.ShareSessionQrCode, err error) {

// GetShareSessionQrCode retrieves a session QR code based on generated Qr ID

func (client *DigitalIdentityClient) GetShareSessionQrCode(qrCodeId string) (share digitalidentity.ShareSessionQrCode, err error) {

comment + func name (i haven't checked other sdks so happy to just have it all align with whatever they have)

klaidas · 2023-11-02T00:47:34Z

digitalidentity/service_test.go

@@ -127,3 +127,22 @@ func TestCreateQrCode(t *testing.T) {
 	_, err := CreateShareQrCode(client, mockSessionID, "sdkId", "https://apiurl", key)
 	assert.NilError(t, err)
 }
+
+func TestGetQrCode(t *testing.T) {


Suggested change

func TestGetQrCode(t *testing.T) {

func GetShareSessionQrCode(t *testing.T) {

klaidas · 2023-11-02T00:49:51Z

digitalidentity/service.go

@@ -113,3 +114,34 @@ func CreateShareQrCode(httpClient requests.HttpClient, sessionID string, clientS
 	err = json.Unmarshal(responseBytes, qrCode)
 	return qrCode, err
 }
+
+// GetShareSessionQrCode is used to fetch the qr code by  id.


Suggested change

// GetShareSessionQrCode is used to fetch the qr code by id.

// GetShareSessionQrCode is used to fetch the qr code by id.

extra space

klaidas

couple minor fixes we can still do, but after that LGTM

…to SDK-2259-go-retrieve-qr-code

…escriptions

…dling, simplified some functions

Co-authored-by: Klaidas Urbanavicius <[email protected]>

…nto base func. etc

…etrieve-receipt

Co-authored-by: Klaidas Urbanavicius <[email protected]>

…texts

Co-authored-by: Klaidas Urbanavicius <[email protected]>

Sdk 2235 share v 2 retrieve receipt

mehmet-yoti added 6 commits October 22, 2023 23:53

SDK-2259:added retrieve qr code

6691dec

SDK-2235 added retrieve receipt

be2b96b

SDK-2235 Added Retrieve Receipt

6f50c88

SDK-2235 Added Retrieve Receipt

fb79e33

SDK-2235 Added Retrieve Receipt

1586dea

SDK-2235 Added Retrieve Receipt

c2d3b6c

mehmet-yoti requested review from fofiuiancu and klaidas October 25, 2023 13:02

irotech reviewed Oct 31, 2023

View reviewed changes

klaidas reviewed Oct 31, 2023

View reviewed changes

mehmet-yoti added 4 commits November 1, 2023 11:16

SDK-2254 Resolved pr comments

22d0896

SDK-2259:updated needed pr reviews

359a293

SDK-2259:updated needed pr reviews

cb5f083

SDK-2259:updated needed pr reviews

ce57837

mehmet-yoti requested review from klaidas and irotech November 1, 2023 11:28

klaidas reviewed Nov 2, 2023

View reviewed changes

klaidas approved these changes Nov 2, 2023

View reviewed changes

mehmet-yoti and others added 11 commits November 7, 2023 08:02

SDK-2254 Resolved pr comments

f61e496

SDK-2254:updated pr changes

708fe86

SDK-2254 removed unused builder

2a0f087

SDK-2259:added retrieve qr code

5912800

SDK-2254 Removed unused examples and updated function namings

e4a1fc8

SDK-2259:updated needed pr reviews

06d91c3

SDK-2259:removed unused example files

f410402

Merge remote-tracking branch 'origin/SDK-2259-go-retrieve-qr-code' in…

fd1f342

…to SDK-2259-go-retrieve-qr-code

SDK-2259:added retrieve qr code structs

86d40a4

SDK-2254 Removed unused examples and updated function namings

60e2f4d

SDK-2259:removed unused example files

7a955f4

mehmet-yoti and others added 29 commits November 7, 2023 23:11

SDK-2254 removed unused builder

ad1f3f9

SDK-2259:added retrieve qr code structs

87d61de

SDK-2254 Removed unused examples and updated function namings

6c2d312

SDK-2259:removed unused example files

d40c218

SDK-2254 Removed unused examples and updated function namings

f8657c2

SDK-2259:removed unused example files

4c019b3

SDK-2235:error handling, updated comments

a841a3e

SDK-2235:updated method descriptions and addedd error handlers with d…

87f5098

…escriptions

SDK-2235:added some error handling, updated comments, added error han…

2492915

…dling, simplified some functions

Update digitalidentity/service.go

5bf052f

Co-authored-by: Klaidas Urbanavicius <[email protected]>

Update digitalidentity/service.go

9661755

Co-authored-by: Klaidas Urbanavicius <[email protected]>

Update digitalidentity/service.go

75502ef

Co-authored-by: Klaidas Urbanavicius <[email protected]>

Update digitalidentity/service.go

b7d7b23

Co-authored-by: Klaidas Urbanavicius <[email protected]>

Update digitalidentity/service.go

8e20b5e

Co-authored-by: Klaidas Urbanavicius <[email protected]>

Update digitalidentity/service.go

b893957

Co-authored-by: Klaidas Urbanavicius <[email protected]>

Update digitalidentity/service.go

4993e35

Co-authored-by: Klaidas Urbanavicius <[email protected]>

Update cryptoutil/crypto_utils.go

e52a26c

Co-authored-by: Klaidas Urbanavicius <[email protected]>

Update digitalidentity/service.go

b9d8fed

Co-authored-by: Klaidas Urbanavicius <[email protected]>

Update cryptoutil/crypto_utils.go

c09c2c2

Co-authored-by: Klaidas Urbanavicius <[email protected]>

SDK-2235: added error details, cleaned unneccessary func and merged i…

8dd3c7c

…nto base func. etc

Merge branch 'SDK-2259-go-retrieve-qr-code' into SDK-2235-share-v-2-r…

f705d44

…etrieve-receipt

Update cryptoutil/crypto_utils.go

a4775d2

Co-authored-by: Klaidas Urbanavicius <[email protected]>

SDK-2235:reduced complexity

3da5372

SDK-2235 removed unused method, added panic controls, added error con…

9d403b8

…texts

SDK-2235 added error contexts

af99524

Update digitalidentity/service.go

a3d8314

Co-authored-by: Klaidas Urbanavicius <[email protected]>

Update digitalidentity/service.go

5f1ec57

Co-authored-by: Klaidas Urbanavicius <[email protected]>

SDK-2235 updated error context text

3fb2de7

Merge pull request #289 from getyoti/SDK-2235-share-v-2-retrieve-receipt

ac64677

Sdk 2235 share v 2 retrieve receipt

mehmet-yoti merged commit fb179ee into SDK-2254-go-create-qr-code Dec 14, 2023
5 of 6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SDK-2259:added retrieve qr code #290

SDK-2259:added retrieve qr code #290

mehmet-yoti commented Oct 25, 2023

irotech Oct 31, 2023

mehmet-yoti Nov 1, 2023

irotech Oct 31, 2023

mehmet-yoti Nov 1, 2023

irotech Oct 31, 2023

klaidas Oct 31, 2023

mehmet-yoti Nov 1, 2023

irotech Nov 1, 2023 •

edited

Loading

klaidas Nov 2, 2023

irotech Nov 7, 2023

irotech Oct 31, 2023

mehmet-yoti Nov 1, 2023

klaidas Oct 31, 2023

klaidas Nov 2, 2023

klaidas Nov 2, 2023

klaidas Nov 2, 2023

klaidas left a comment

		// Get Share QR info using the supplied sessionID
		func GetShareQr(httpClient requests.HttpClient, sessionID string, clientSdkId, apiUrl string, key *rsa.PrivateKey) (share ShareSessionFetchedQrCode, err error) {

		// Get session QR code based on generated Qr ID
		func (client *DigitalIdentityClient) GetQrCode(qrCodeId string) (share digitalidentity.ShareSessionFetchedQrCode, err error) {

	func TestGetQrCode(t *testing.T) {
	func GetShareSessionQrCode(t *testing.T) {

	// GetShareSessionQrCode is used to fetch the qr code by id.
	// GetShareSessionQrCode is used to fetch the qr code by id.

SDK-2259:added retrieve qr code #290

SDK-2259:added retrieve qr code #290

Conversation

mehmet-yoti commented Oct 25, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

irotech Nov 1, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

klaidas left a comment

Choose a reason for hiding this comment

irotech Nov 1, 2023 •

edited

Loading