Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sdk 2242 digital identity share v2 #415

Open
wants to merge 12 commits into
base: development
Choose a base branch
from

Conversation

mehmet-yoti
Copy link
Contributor

No description provided.

Copy link

@saurabh-yoti saurabh-yoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid the need for a JSON session config while creating Share v2 session, we need to implement additional builders for Share v2 - Policy, Extensions, Constraints, Wanted.

This is in line with Other SDKs that have added Digital Identity (Share v2) support. Please refer to them.

@@ -65,7 +65,7 @@ <h3 class="yoti-sponsor-app-header">The Yoti app is free to download and use:</h
</section>
</main>

<script src="https://www.yoti.com/share/client/"></script>
<script src="https://www.public.stg1.dmz.yoti.com/share/client"></script>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change back to the Prod URL.

@@ -62,7 +62,7 @@ <h3 class="yoti-sponsor-app-header">The Yoti app is free to download and use:</h
</div>
</section>
</main>
<script src="https://www.yoti.com/share/client/"></script>
<script src="https://connect.public.stg1.dmz.yoti.com/share/client/"></script>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change back to the Prod URL.

@@ -5,6 +5,7 @@


class DynamicScenarioBuilder(object):
print("Hello, World!")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the print statement.

@@ -15,6 +15,7 @@ def __init__(self, profile_attributes):

if profile_attributes:
for field in profile_attributes:
# print("field %s" % field)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the commented print statement.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this key.

"subject_id": "some_subject_id_string"
}, # Optional reference to a user ID
"notification": {
"url": "https://webhook.site/818dc66b-e18b-4767-92c5-47c7af21629c",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better to change URL to https://example.com/webhook-url.

domId: 'webshare-target',
sdkId: '99525f08-afbb-4420-98b9-0717309f7fed',
skinId: 'yoti',
flow: 'INLINE_QR',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INLINE_QR is a legacy value. Please change that to INSTANT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants