[NO_TICKET]Add image format information in supplier endpoint #59
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spec/components/schema/supplier.yaml
Outdated
| @@ -41,7 +41,7 @@ components: | |||
| logo_url: | |||
| type: string | |||
| format: uri | |||
| description: URL to the logo of the supplier. | |||
| description: URL to the logo of the supplier. Important, the [format_id] needs to be replaced by a valid format id. You can find the list of all available ids in https://github.com/getyourguide/partner-api-spec/wiki/Image-Formats. | |||
There was a problem hiding this comment.
Do you mind adding it to other places as well? Like in the picture.yaml file?
There was a problem hiding this comment.
Do you mean the link itself ?
There was a problem hiding this comment.
Yes, exactly. The format_id is already mentioned in the pictures.yaml with instructions to replace with a proper value from the "wiki". Let's add the link there too. WDYT?
selinbarash
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding format id information for the supplier endpoint
Checklist:
Screenshot (Optional)
New features / fixes can include a gif or screenshot of the functionality.